Skip to content

feat: patching with update control #1147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 7, 2022
Merged

feat: patching with update control #1147

merged 4 commits into from
Apr 7, 2022

Conversation

csviri
Copy link
Collaborator

@csviri csviri commented Apr 7, 2022 •
edited
Loading

Ability to patch resource and status using UpdateControl.

@csviri csviri changed the title feat: patching in update control feat: patching with update control Apr 7, 2022
@csviri csviri self-assigned this Apr 7, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

68.1% 68.1% Coverage
0.0% 0.0% Duplication

@csviri csviri marked this pull request as ready for review April 7, 2022 12:04
@csviri csviri requested a review from metacosm April 7, 2022 12:04
metacosm
metacosm approved these changes Apr 7, 2022
View reviewed changes
Copy link
Collaborator

@metacosm metacosm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though it's quite dangerous to do this kind of change now.

@csviri
Copy link
Collaborator Author

csviri commented Apr 7, 2022

It's not ideal to do it now before the release for sure. On the other hand it's quite simple change. Will merge and in case of any issues in RC we can still revert.

@csviri csviri merged commit e4790d6 into main Apr 7, 2022
@csviri csviri deleted the patch-update-control branch April 7, 2022 13:56
@csviri csviri mentioned this pull request Apr 19, 2022
Closed
@csviri csviri linked an issue Apr 19, 2022 that may be closed by this pull request
Using patch when updating status sub-resource (or update without optimistic locking) #525
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metacosm metacosm metacosm approved these changes

Assignees

@csviri csviri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using patch when updating status sub-resource (or update without optimistic locking)
2 participants
@csviri @metacosm